fix: preserve cached table list shape#10179
Open
memleakd wants to merge 2 commits intocodeigniter4:developfrom
Open
fix: preserve cached table list shape#10179memleakd wants to merge 2 commits intocodeigniter4:developfrom
memleakd wants to merge 2 commits intocodeigniter4:developfrom
Conversation
5 tasks
paulbalandan
approved these changes
May 10, 2026
michalsn
reviewed
May 10, 2026
Member
michalsn
left a comment
michalsn
left a comment
There was a problem hiding this comment.
We still need a changelog entry for this one.
michalsn
added
the
bug
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
Contributor
Author
Added in 9a4613b. Thank you! |
michalsn
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserves the documented
list<string>return shape ofBaseConnection::listTables()when returning cached table names.When a table is dropped, the cached table-name array may become sparse. Returning
array_values()from the cached path keeps the result as a proper list, matching the method PHPDoc and the fresh-query path.This was split out from #10169 after review because it is a small database metadata fix with its own regression coverage.
Checklist: